Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(falco): enable CLI options with -o key={object} #3310

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine

What this PR does / why we need it:

In #3308 we add a new configuration option such as:

append_output:
  - source: syscall
    tag: persistence
    rule: some rule name
    format: "gparent=%proc.aname[2] ggparent=%proc.aname[3] gggparent=%proc.aname[4]"

Given its format, it is not possible to specify it on the command line with a -o option unless we enable a syntax like -o key={object}, or -o key[]={object}. Example: -o append_output[]={"source": "syscall", "tag": "persistence", "rule": "some rule name", "format": "gparent=%proc.aname[2] ggparent=%proc.aname[3] gggparent=%proc.aname[4]"}. This PR does exactly that.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

For now, we are not enabling lists here but they can be allowed as well.

Does this PR introduce a user-facing change?:

new(falco): enable CLI options with -o key={object}

@LucaGuerra
Copy link
Contributor Author

/milestone 0.39.0

@poiana poiana added this to the 0.39.0 milestone Sep 3, 2024
@LucaGuerra LucaGuerra force-pushed the new/dash-o-object-config branch from 1f753f1 to 46d77ec Compare September 3, 2024 15:29
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Neat, thanks!

@poiana
Copy link
Contributor

poiana commented Sep 4, 2024

LGTM label has been added.

Git tree hash: a28816c9866ca21508908e207b9cc088b378f1fe

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 36d6951 into falcosecurity:master Sep 6, 2024
33 checks passed
@LucaGuerra LucaGuerra deleted the new/dash-o-object-config branch September 6, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants