-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(falco): add deprecation notice for -T, -t and -D #3193
update(falco): add deprecation notice for -T, -t and -D #3193
Conversation
Signed-off-by: Luca Guerra <[email protected]>
Shouldn't we also warn the user through a log when these cmdline options are used? |
@FedeDP sure, added a commit for it :) |
Signed-off-by: Luca Guerra <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]> Co-authored-by: Melissa Kilby <[email protected]>
74f3870
to
ebffe10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 3e99c9fc77e536625f7faf21dd46bf49b74821a4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.38.0 |
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
As per discussion in #3174 (comment) . This only deprecates the CLI option and offers an alternative, does not remove it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: