chore: bump to latest libs commit #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Andreagit97
force-pushed
the
bump_falco_latest_libs
branch
from
1f4ef40 to
d84795c
Compare
Andreagit97
force-pushed
the
bump_falco_latest_libs
branch
2 times, most recently
from
c6c5910 to
30c9450
Compare
Signed-off-by: Andrea Terzolo <[email protected]>
Andreagit97
force-pushed
the
bump_falco_latest_libs
branch
from
30c9450 to
ae34190
Compare
|
This diff can fix the CI, but I would prefer to fix in other ways if possible, for example bumping the ubuntu version in the CI job, let's see... @@ -17,8 +17,8 @@ option(USE_BUNDLED_CPPHTTPLIB "Enable building of the bundled cpp-httplib" ${USE
if(USE_BUNDLED_CPPHTTPLIB)
include(FetchContent)
FetchContent_Declare(cpp-httplib
- URL https://github.com/yhirose/cpp-httplib/archive/refs/tags/v0.15.3.tar.gz
- URL_HASH SHA256=2121bbf38871bb2aafb5f7f2b9b94705366170909f434428352187cb0216124e
+ URL https://github.com/yhirose/cpp-httplib/archive/refs/tags/v0.13.1.tar.gz
+ URL_HASH SHA256=9b837d290b61e3f0c4239da0b23bbf14c382922e2bf2a9bac21c1e3feabe1ff9
)
FetchContent_MakeAvailable(cpp-httplib)
else() |
|
ok bumping the job to Ubuntu 22.04 fixed it! |
|
LGTM label has been added. Git tree hash: 6370a70e13ddee9c342913a9a13199781977fad9
|
LucaGuerra
approved these changes
Mar 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR bumps Falco with the latest libs
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: