-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): Avoid using command make directly #3101
refactor(ci): Avoid using command make directly #3101
Conversation
aa113a5
to
95cd30d
Compare
LGTM label has been added. Git tree hash: b56cfc93f03c21adff2ad484eb55cd6b4ce0e591
|
Signed-off-by: Federico Aponte <[email protected]>
95cd30d
to
bf644ae
Compare
ARM tests are failing cc @FedeDP |
Flaky :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 26ebf182b1ae44192c0cf706db80163d5a2bc71a
|
/milestone 0.38.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, federico-sysdig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area CI
What this PR does / why we need it:
Simplifies a bit the configure/generate phase of CMake by letting it create the
build
directory.Avoids invoking the command
make
directly and relying on CMake instead, thus preparing the build to be used with other build systems, such as Ninja.Ninja could be easily used after this change just by adding the switch
-G Ninja
to the CMake configure/generate statement. For instance:In a nutshell this PR realizes the following transformation:
Old:
New:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I also simplified the download of the updated version of CMake so that it won't require uncompressing the binaries to a temporary directory that needs to be eventually deleted.
Does this PR introduce a user-facing change?: