Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): Avoid using command make directly #3101

Conversation

federico-sysdig
Copy link
Contributor

@federico-sysdig federico-sysdig commented Feb 19, 2024

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build
/area CI

What this PR does / why we need it:

Simplifies a bit the configure/generate phase of CMake by letting it create the build directory.
Avoids invoking the command make directly and relying on CMake instead, thus preparing the build to be used with other build systems, such as Ninja.

Ninja could be easily used after this change just by adding the switch -G Ninja to the CMake configure/generate statement. For instance:

cmake -B build -S . -G Ninja -DCMAKE_BUILD_TYPE=Release -Dparameter=value

In a nutshell this PR realizes the following transformation:

Old:

mkdir build
pushd build
cmake -Dparameter=value ..
build -j4 my_exe
popd

New:

cmake -B build -S . -Dparameter=value
cmake --build build -j4 --target my_exe

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

I also simplified the download of the updated version of CMake so that it won't require uncompressing the binaries to a temporary directory that needs to be eventually deleted.

Does this PR introduce a user-facing change?:

NONE

leogr
leogr previously approved these changes Feb 26, 2024
@poiana
Copy link
Contributor

poiana commented Feb 26, 2024

LGTM label has been added.

Git tree hash: b56cfc93f03c21adff2ad484eb55cd6b4ce0e591

@leogr
Copy link
Member

leogr commented Feb 29, 2024

ARM tests are failing cc @FedeDP

@FedeDP
Copy link
Contributor

FedeDP commented Mar 7, 2024

Flaky :)

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 7, 2024

LGTM label has been added.

Git tree hash: 26ebf182b1ae44192c0cf706db80163d5a2bc71a

@poiana poiana added the approved label Mar 7, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Mar 7, 2024

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone Mar 7, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, federico-sysdig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3954ff2 into falcosecurity:master Mar 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants