[BREAKING CHANGE]: cleanup(falco.yaml)!: remove some deprecated configs #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeDP
previously approved these changes
Feb 14, 2024
|
LGTM label has been added. Git tree hash: 7f053837075fe63cbf96638ea261981049e91997
|
|
The win32 failure: |
Andreagit97
force-pushed
the
remove_deprecated_options
branch
from
a9796e6 to
13cab3f
Compare
11 tasks
|
LGTM label has been added. Git tree hash: 4fda36d4c42401e0ee68a635db1bc7e9bc81fd29
|
|
we need to change also the corresponding tests in |
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Andreagit97
force-pushed
the
remove_deprecated_options
branch
from
13cab3f to
f70c4b8
Compare
|
This should be ready now! |
|
LGTM label has been added. Git tree hash: abe7853ec241d7cdd6d5cbf0e797c1ae4c3ff39c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
As previously described in this issue #2840, this PR removes the deprecated features
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: