update(userspace/falco): revised CLI help messages #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incertum
reviewed
Sep 1, 2023
userspace/falco/app/options.cpp
Outdated
| ("S,snaplen", "Collect only the first <len> bytes of each I/O buffer for 'syscall' events. By default, the first 80 bytes are collected by the driver and sent to the user space for processing. Use this option with caution since it can have a strong performance impact.", cxxopts::value(snaplen)->default_value("0"), "<len>") | ||
| ("support", "Print support information, including version, rules files used, loaded configuration, etc., and exit. The output is in JSON format.", cxxopts::value(print_support)->default_value("false")) | ||
| ("T", "Turn off any rules with a tag=<tag>. This option can be passed multiple times. This option can not be mixed with -t.", cxxopts::value<std::vector<std::string>>(), "<tag>") | ||
| ("t", "Only enable those rules with a tag=<tag> and turn off others. This option can be passed multiple times. This option can not be mixed with -T/-D.", cxxopts::value<std::vector<std::string>>(), "<tag>") |
There was a problem hiding this comment.
probably don't need and turn off others seems redundant and perhaps confusing.
Andreagit97
reviewed
Sep 1, 2023
leogr
commented
Sep 4, 2023
leogr
force-pushed
the
update/cli-help-messages
branch
from
3a3565c to
f38bf43
Compare
Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Melissa Kilby <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
update/cli-help-messages
branch
from
f38bf43 to
6d276ac
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
What this PR does / why we need it:
Revise all CLI help messages according to latest definitions and correct various errors and typos.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/milestone 0.36.0
Does this PR introduce a user-facing change?: