-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wget and curl to remote_file_copy_binaries #1771
Add wget and curl to remote_file_copy_binaries #1771
Conversation
Hey @ec4n6 Tests are failing 👇
I guess the round brackets are not needed around strings. |
LGTM label has been added. Git tree hash: e012ad4708ea6ca230b33bcc2d575d6d6f99f1af
|
Closing and reopening to trigger the CI |
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone 0.31.0 |
Signed-off-by: Erick Cheng <[email protected]>
Signed-off-by: Erick Cheng <[email protected]>
Signed-off-by: Erick Cheng <[email protected]>
Signed-off-by: Erick Cheng <[email protected]>
Signed-off-by: Erick Cheng <[email protected]>
200231c
to
ef98d58
Compare
@leogr Hi, it looks like my merge is missing the DCO signoff. Is this necessary, and if so, how do I add signoff to an existing merge? |
/check-dco |
Merge commits are not allowed, but it seems to me you already removed it. Indeed, after checking for DCO again, now it's all fine. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 788fefea0a448c7688afcf4b2905e05092b73dc9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ec4n6, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump @Kaizhe |
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Added additional binaries that are capable of remote file copy. These binaries are commonly used as a prerequisite to command and control.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?: