Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): correct lookup order when trying multiple gcc versions in the falco-driver-loader script #1716

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

Spartan-65
Copy link
Contributor

@Spartan-65 Spartan-65 commented Aug 30, 2021

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

Which issue(s) this PR fixes:

This PR set falco-driver-loader ENABLE_DOWNLOAD useful.

and try gcc version from high to low

before

 $ls ./gcc-* | grep 'gcc-[0-9]\+' | sort -r
./gcc-9
./gcc-8
./gcc-3
./gcc-2
./gcc-11
./gcc-10
./gcc-1

now

$ ls ./gcc-* | grep 'gcc-[0-9]\+' | sort -n -r -k 2 -t - 
./gcc-11
./gcc-10
./gcc-9
./gcc-8
./gcc-3
./gcc-2
./gcc-1

Fixes #

fix(scripts): correct lookup order when trying multiple `gcc` versions in the `falco-driver-loader` script

@poiana
Copy link
Contributor

poiana commented Aug 30, 2021

Welcome @Spartan-65! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Aug 30, 2021
@leogr
Copy link
Member

leogr commented Sep 2, 2021

Hey @Spartan-65

Could you sign off your commit, please?

@Spartan-65
Copy link
Contributor Author

Hey @Spartan-65

Could you sign off your commit, please?

sorry for the problem :)

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question (see comments below). Otherwise SGTM.

Thank you!

@leogr
Copy link
Member

leogr commented Sep 13, 2021

/milestone 0.30.0

@poiana poiana added this to the 0.30.0 milestone Sep 13, 2021
@Spartan-65 Spartan-65 force-pushed the fix-bugs branch 2 times, most recently from a7c2ce7 to eac73ff Compare September 21, 2021 08:29
Signed-off-by: Spartan-65 <[email protected]>
@leogr leogr changed the title fix small bugs fix(scripts): correct lookup order when trying multiple gcc versions in the falco-driver-loader script Sep 21, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/approve
/cc @leodido
/cc @fntlnz

@poiana poiana requested review from fntlnz and leodido September 21, 2021 10:56
@poiana poiana added the lgtm label Sep 21, 2021
@poiana
Copy link
Contributor

poiana commented Sep 21, 2021

LGTM label has been added.

Git tree hash: b4da32dea7f801ad20f2e97336c705773bb623e7

@poiana
Copy link
Contributor

poiana commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, Spartan-65

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7c9ec9f into falcosecurity:master Sep 21, 2021
@Spartan-65 Spartan-65 deleted the fix-bugs branch June 19, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants