-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scripts): correct lookup order when trying multiple gcc
versions in the falco-driver-loader
script
#1716
Conversation
Welcome @Spartan-65! It looks like this is your first PR to falcosecurity/falco 🎉 |
Hey @Spartan-65 Could you sign off your commit, please? |
sorry for the problem :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question (see comments below). Otherwise SGTM.
Thank you!
/milestone 0.30.0 |
a7c2ce7
to
eac73ff
Compare
Signed-off-by: Spartan-65 <[email protected]>
eac73ff
to
aa5bb2e
Compare
gcc
versions in the falco-driver-loader
script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: b4da32dea7f801ad20f2e97336c705773bb623e7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, Spartan-65 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
Which issue(s) this PR fixes:
This PR set
falco-driver-loader
ENABLE_DOWNLOAD
useful.and try
gcc
version from high to lowbefore
now
Fixes #