fix(userspace): handle exceptions for process_k8s_audit_event #1617
Conversation
|
LGTM label has been added. Git tree hash: c40a9a670db0c63db0fdefeecd2c7eee207b7b65
|
|
/milestone 0.28.1 |
|
Closing and reopening to trigger the CI again |
|
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fix has two major points in it: - when `std::stoll` is used in parse_as_int64 handle all the exceptions it can throw (https://en.cppreference.com/w/cpp/string/basic_string/stol) - when `process_k8s_audit_event` an eventual exception in it does not stop the webserver process. This is done by doing a catch all handle outside it and by logging an error message to the caller as well as in stderr Signed-off-by: Lorenzo Fontana <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fix has two major points in it:
std::stollis used in parse_as_int64 handle all the exceptions itcan throw (https://en.cppreference.com/w/cpp/string/basic_string/stol)
process_k8s_audit_eventan eventual exception in it does notstop the webserver process. This is done by doing a catch all handle
outside it and by logging an error message to the caller as well as in
stderr
Signed-off-by: Lorenzo Fontana [email protected]
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1575
Special notes for your reviewer:
Does this PR introduce a user-facing change?: