Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup publishing jobs #1596

Merged
merged 3 commits into from
Apr 7, 2021
Merged

cleanup publishing jobs #1596

merged 3 commits into from
Apr 7, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented Mar 29, 2021

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

This is just a follow-up of #1577 (and subsequent PRs). It cleans up a now unnecessary job/script and fixes some minor issues/typos in docs and comments. No running code/configs are affected.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

leogr and others added 3 commits March 29, 2021 12:11
Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Applying suggestions from
#1577

Co-authored-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Applying suggestions from #1577

Co-authored-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
@poiana
Copy link
Contributor

poiana commented Mar 30, 2021

LGTM label has been added.

Git tree hash: 4267157a82dc41b4b7b9182e5d937374ba55c3a0

@leogr
Copy link
Member Author

leogr commented Apr 7, 2021

/milestone 0.28.0

@poiana poiana added this to the 0.28.0 milestone Apr 7, 2021
@poiana
Copy link
Contributor

poiana commented Apr 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7998560 into master Apr 7, 2021
@poiana poiana deleted the cleanup/publishing-jobs branch April 7, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants