-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flex to docker for building bpf module on recent amazon linux2 #1562
Conversation
/assign @leogr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM label has been added. Git tree hash: 151d00e663a34aa782fab9bc78eb6471827bedaf
|
/milestone 0.28.0 |
/cc @leodido |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should also add bison
. Left a suggestion
Hey @schans, Could you sign-off the last commit pls? |
… linux2 Signed-off-by: Bart van der Schans <[email protected]>
4e5bdbe
to
4a5b858
Compare
Hi @leodido , I have added bison, squashed the commits and added the sign off. Hopefully we're good to go ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
LGTM label has been added. Git tree hash: 9f97b2d2201ad6c0ea8e970c58b36ad95ef29f17
|
Looks like we are really close to merging ;-) Anything I can do to help to push this over the line? |
You did already a lot! :) Now we have just to wait for another maintainer who will double-check and approve eventually. I'm confident that will happen within the 0.28.0 time window. 👍 Thank you again |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Flex is needed for building bpf module on recent amazon linux images.
#1558
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
The bpf module fails to build on recent amazon linux2 versions with docker (k8s) deploys.
Which issue(s) this PR fixes:
#1558
Fixes #1558
Special notes for your reviewer:
Does this PR introduce a user-facing change?: