Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flex to docker for building bpf module on recent amazon linux2 #1562

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

schans
Copy link
Contributor

@schans schans commented Feb 21, 2021

Flex is needed for building bpf module on recent amazon linux images.

#1558

What type of PR is this?

Uncomment one (or more) /kind <> lines:
/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:
/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
The bpf module fails to build on recent amazon linux2 versions with docker (k8s) deploys.

Which issue(s) this PR fixes:
#1558

Fixes #1558

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(docker/falco): add flex and bison dependency to container image

@schans
Copy link
Contributor Author

schans commented Feb 22, 2021

/assign @leogr

leogr
leogr previously approved these changes Feb 22, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana added the lgtm label Feb 22, 2021
@poiana
Copy link
Contributor

poiana commented Feb 22, 2021

LGTM label has been added.

Git tree hash: 151d00e663a34aa782fab9bc78eb6471827bedaf

@leogr
Copy link
Member

leogr commented Feb 22, 2021

/milestone 0.28.0

@poiana poiana added this to the 0.28.0 milestone Feb 22, 2021
@leogr
Copy link
Member

leogr commented Feb 22, 2021

/cc @leodido

@poiana poiana requested a review from leodido February 22, 2021 09:55
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should also add bison. Left a suggestion

docker/falco/Dockerfile Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Feb 22, 2021

Hey @schans,

Could you sign-off the last commit pls?

@schans
Copy link
Contributor Author

schans commented Feb 22, 2021

Hi @leodido ,

I have added bison, squashed the commits and added the sign off. Hopefully we're good to go ;-)

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana poiana added the lgtm label Feb 22, 2021
@poiana
Copy link
Contributor

poiana commented Feb 22, 2021

LGTM label has been added.

Git tree hash: 9f97b2d2201ad6c0ea8e970c58b36ad95ef29f17

@schans
Copy link
Contributor Author

schans commented Feb 24, 2021

Looks like we are really close to merging ;-) Anything I can do to help to push this over the line?

@leogr
Copy link
Member

leogr commented Feb 25, 2021

Looks like we are really close to merging ;-) Anything I can do to help to push this over the line?

You did already a lot! :)

Now we have just to wait for another maintainer who will double-check and approve eventually. I'm confident that will happen within the 0.28.0 time window. 👍

Thank you again

@poiana
Copy link
Contributor

poiana commented Mar 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 05545f2 into falcosecurity:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flex missing when building ebpf module on amazon linux2
4 participants