patch the max_consumers parameter of the Falco kernel-module driver #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @fntlnz |
kernel-module Falco driver Co-authored-by: Lorenzo Fontana <[email protected]> Signed-off-by: Leonardo Di Donato <[email protected]>
leodido
force-pushed
the
fix/max-consumer-driver-param-patch
branch
from
60279c6 to
5f34784
Compare
leogr
approved these changes
Nov 13, 2020
Comment on lines
+45
to
+48
| - if(udig_alloc_ring_descriptors(&(handle->m_devs[0].m_bufinfo_fd), | ||
| - &handle->m_devs[0].m_bufinfo, | ||
| + if(udig_alloc_ring_descriptors(&(handle->m_devs[0].m_bufinfo_fd), | ||
| + &handle->m_devs[0].m_bufinfo, |
There was a problem hiding this comment.
I would not include those cleaning of whitespaces in the patch unless there's a reason I did not understand; otherwise, it looks good to me.
|
LGTM label has been added. Git tree hash: 7a2672688b5a55482e903474bca0f98b19f627b9
|
fntlnz
approved these changes
Nov 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Lorenzo Fontana [email protected]
Signed-off-by: Leonardo Di Donato [email protected]
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
This bug happens when many Falco instances start because the check of how many driver consumers can work at the same time is not correct.
Does this PR introduce a user-facing change?: