Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new DRIVERS_REPO default URL #1460

Merged
merged 2 commits into from
Oct 28, 2020
Merged

new DRIVERS_REPO default URL #1460

merged 2 commits into from
Oct 28, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Oct 27, 2020

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

/area proposals

What this PR does / why we need it:

It replaces the default value of DRIVERS_REPO variable with the new drivers storage on AWS S3 (as per @fntlnz's proposal).

The new storage is at https://download.falco.org

Which issue(s) this PR fixes:

Fixes #1458
Fixes #1455

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update: DRIVERS_REPO now defaults to https://download.falco.org/driver

leodido and others added 2 commits October 27, 2020 16:18
…cts storage proposals

Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
Co-authored-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
@leodido
Copy link
Member Author

leodido commented Oct 27, 2020

/cc @leogr
/cc @fntlnz

@poiana poiana requested review from fntlnz and leogr October 27, 2020 16:22
@leodido
Copy link
Member Author

leodido commented Oct 27, 2020

/milestone 0.26.2

@poiana poiana added this to the 0.26.2 milestone Oct 27, 2020
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Bravo! 👏

@poiana
Copy link
Contributor

poiana commented Oct 27, 2020

LGTM label has been added.

Git tree hash: ca6405396198fd7b367e05964f0058827f08348c

@poiana
Copy link
Contributor

poiana commented Oct 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b3679f8 into master Oct 28, 2020
@poiana poiana deleted the new/driversrepo branch October 28, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing falco on CentOS is failing 403 forbidden due to repository 403 when fetching prebuilt driver
4 participants