update: bump Falco engine version to 7 #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
update/engine-version-7
branch
from
2b16191 to
f384dac
Compare
fntlnz
approved these changes
Sep 11, 2020
|
LGTM label has been added. Git tree hash: e936bbc26da0bbdeb6738802e31f8b18b74c5518
|
mstemm
reviewed
Sep 13, 2020
| @@ -16,7 +16,7 @@ limitations under the License. | |||
|
|
|||
| // The version of rules/filter fields/etc supported by this falco | |||
| // engine. | |||
| #define FALCO_ENGINE_VERSION (6) | |||
| #define FALCO_ENGINE_VERSION (7) | |||
There was a problem hiding this comment.
I see that FALCO_FIELDS_CHECKSUM was already updated with the new checksum, great. Generally, whenever that checksum changes, the engine version needs to change too.
mstemm
approved these changes
Sep 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area engine
/area rules
What this PR does / why we need it:
This PR bumps the engine version to the expected number (7), as per https://falco.org/docs/rules/#versioning
Furthermore, it also sets the
required_engine_versionto 7 in the rule files, to show the expected error when the ruleset does not match. Unfortunately, this must be set to the entire rule files (even though it's required just by few rules) since therequired_engine_versiondoes not work on rule level (thus the PR #1273 is blocked)./milestone 0.26.0
Which issue(s) this PR fixes:
Fixes #1380
Fixes #1272
Special notes for your reviewer:
I'd propose closing the #1273 in favor of this since the current implementation does not support
required_engine_versionat rule level.An alternative of setting the
required_engine_versionto 7 for the whole file is to create a rules file for every version depending on what are the supported fields, as initially proposed in this comment. If we got consensus for this alternative, I will open another PR (since the main purpose of this PR is just to bump the engine version number and not to fix the whole problem).Finally, this PR intentionally does not try to solve the other problem reported by #1277
/cc @fntlnz
/cc @leodido
/cc @mstemm
Does this PR introduce a user-facing change?: