-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added brakets to three macros to make them less ambiguous #1373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
LGTM label has been added. Git tree hash: 86e77e76a89f7194b59d483965177c314a602031
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Loris! 🎉
I've updated the release-note block lines to make them match the guidelines.
Would you please just sign-off your commit and force push it? Thanks again 😃
Signed-off-by: Loris Degioanni <[email protected]>
4fe3399
to
a457c92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind cleanup
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
rules that mix and operators with or operators in a flat way (i.e. without brackets to explicitly separate them) have a couple of challenges:
It turns out that there are only 3 macros in the whole ruleset that mix and and or operators without brakets. This PR modifies them by adding the required brakets.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: