Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip:fix(scripts): modprobe before starting Falco #1365

Closed
wants to merge 2 commits into from

Conversation

leogr
Copy link
Member

@leogr leogr commented Aug 25, 2020

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Running modprobe in deb/rpm scripts was originally introduced by 32f8e30 as backup mechanism since the Falco binary is loading the module by itself.

Anyway, we have noticed that the module is not loaded all the time (especially when the daemon starts during the boot process).

TODO: We need to investigate more

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/cc @fntlnz

Does this PR introduce a user-facing change?:

fix(scripts): run `modprobe` before starting Falco in deb/rpm scripts.

@poiana
Copy link
Contributor

poiana commented Aug 25, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the size/S label Aug 25, 2020
@leogr
Copy link
Member Author

leogr commented Aug 25, 2020

/milestone 0.25.0

@poiana poiana added this to the 0.25.0 milestone Aug 25, 2020
@leogr leogr changed the title fix(scripts): modprobe before starting Falco wip:fix(scripts): modprobe before starting Falco Aug 25, 2020
@leogr
Copy link
Member Author

leogr commented Aug 25, 2020

/milestone 0.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants