-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct stdout output buffering option #1296
Conversation
This explain why `buffered_output: false` was not honored for stdout Signed-off-by: Leonardo Grasso <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good catch! Grazie!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! LGTM
LGTM label has been added. Git tree hash: 17a01a8e21096ce4b8b9c263d30521da8c4464c9
|
1 similar comment
LGTM label has been added. Git tree hash: 17a01a8e21096ce4b8b9c263d30521da8c4464c9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/honk |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
buffered_output: false
was not honored for stdout.This PR corrects the argument wrongly passed to the
stdout_message
that caused the problem aforementioned.Which issue(s) this PR fixes:
Fixes #1198
Fixes #1291
Special notes for your reviewer:
I will add some comments for further improvement.
/cc @fntlnz
/cc @leodido
/milestone 0.24.0
Does this PR introduce a user-facing change?: