rule(macro user_known_write_below_binary_dir_activities) #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…macro This macro is useful to allow binaries to be installed under certain circumstances. For example, it may be fine to install a binary during a build in a ci/cd pipeline. Signed-off-by: Nicolas Marier <[email protected]>
|
/lgtm |
|
LGTM label has been added. Git tree hash: c86979ec2883241e92bc88e296cdcbe393b57424
|
leodido
approved these changes
Jun 22, 2020
fntlnz
approved these changes
Jun 22, 2020
|
Thanks as always @marier-nico - approved and in merge pool |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
This macro is useful to allow binaries to be written under certain circumstances. For example, it may be fine to install a binary during a build in a ci/cd pipeline. A more concrete use-case would be the installation of packer by placing its binary inside the
/bindirectory, which is needed to build AMIs during builds.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: