Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/tests instructions #1199

Merged
merged 4 commits into from
May 14, 2020
Merged

Docs/tests instructions #1199

merged 4 commits into from
May 14, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented May 8, 2020 •
edited by leogr
Loading

Adding some love to our unit-tests documentation to encourage people writing more tests by showing them how they can actually be run, written and filtered.

What type of PR is this?
/kind documentation

Any specific area of the project related to this PR?

/area build

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

docs: instructions to run unit tests

@poiana poiana requested review from krisnova and leodido May 8, 2020 01:46
@poiana poiana added the size/M label May 8, 2020
leodido
leodido reviewed May 8, 2020
View reviewed changes
CONTRIBUTING.md
@@ -11,6 +11,7 @@
- [Rule type](#rule-type)
- [Coding Guidelines](#coding-guidelines)
- [C++](#c)
- [Unit testing](/tests/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to write a section about tests in the organization contributing file too?

leodido
leodido previously approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@leodido leodido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left only a comment.

@leodido leodido added this to the 0.23.0 milestone May 8, 2020
leogr
leogr reviewed May 8, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leogr
leogr requested changes May 11, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found a typo!

tests/README.md Outdated Show resolved Hide resolved
@falcosecurity falcosecurity deleted a comment from poiana May 11, 2020
@fntlnz @leogr
docs(tests): fix typo
b5b03ba 
Co-authored-by: Leonardo Grasso <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
@fntlnz fntlnz force-pushed the docs/tests-instructions branch from bf4bd60 to b5b03ba Compare May 14, 2020 10:47
leogr
leogr approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana poiana added lgtm and removed approved labels May 14, 2020
@poiana
Copy link
Contributor

poiana commented May 14, 2020

LGTM label has been added.

Git tree hash: 4ae21b7c8171637c4e993cedbfc7a8d2e2a0a708

1 similar comment
@poiana
Copy link
Contributor

poiana commented May 14, 2020

LGTM label has been added.

Git tree hash: 4ae21b7c8171637c4e993cedbfc7a8d2e2a0a708

@poiana
Copy link
Contributor

poiana commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented May 14, 2020

/honk

@poiana
Copy link
Contributor

poiana commented May 14, 2020

@leogr:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit d0f4f7c into master May 14, 2020
@poiana poiana deleted the docs/tests-instructions branch May 14, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@leodido leodido leodido approved these changes

@krisnova krisnova Awaiting requested review from krisnova

Assignees

@leodido leodido

@leogr leogr

Labels
approved area/build dco-signoff: yes kind/documentation lgtm release-note size/M
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fntlnz @poiana @leogr @leodido