Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rule naming following naming convention #1164

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Apr 27, 2020

Signed-off-by: kaizhe [email protected]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
Following the rule naming convention to fix the rule name.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Redirect STDOUT/STDIN to Network Connection in Container): correct rule name as per rules naming convention

@poiana
Copy link
Contributor

poiana commented Apr 27, 2020

LGTM label has been added.

Git tree hash: 6e61ea3175e4271f27decc3b4f541578454a01ae

@poiana
Copy link
Contributor

poiana commented Apr 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido
Copy link
Member

leodido commented Apr 27, 2020

Do you need a release-note @Kaizhe?

Otherwise to get it merged you can edit the release-note block inserting NONE.

@Kaizhe
Copy link
Contributor Author

Kaizhe commented Apr 27, 2020

Updated release-note.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana merged commit f27056c into master Apr 28, 2020
@poiana poiana deleted the kh_fix-rule-name branch April 28, 2020 16:18
@leogr leogr added this to the 0.23.0 milestone May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants