-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rule update: only detect sa created in kube namespace with success #1117
Conversation
LGTM label has been added. Git tree hash: 76f5a8791955b4c973f0150dac6e6e69132acdf0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job as always here Kaizhe! As per the other PR, rule changes release notes need to follow the convention here
…ed in kube namespace with success Signed-off-by: kaizhe <[email protected]>
9dce09d
to
94cb95f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kaizhe [email protected]
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
kops
tries to createkube-proxy
andkube-dns
sa inkube-system
namespace every minute which triggers ruleService Account Created in Kube Namespace
. Restrict the condition to only detect a successfully event.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: