fix(c++): add missing overrides

Reported by cppcheck Signed-off-by: Samuel Gaist <[email protected]>
falcosecurity · Feb 8, 2024 · 8579ea6 · 8579ea6
1 parent 7879920
commit 8579ea6
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 19 deletions.
diff --git a/userspace/falco/grpc_request_context.h b/userspace/falco/grpc_request_context.h
@@ -64,9 +64,9 @@ class request_stream_context : public request_context_base
 	// Pointer to function that requests the system to start processing given requests
 	void (Service::AsyncService::*m_request_func)(::grpc::ServerContext*, Request*, ::grpc::ServerAsyncWriter<Response>*, ::grpc::CompletionQueue*, ::grpc::ServerCompletionQueue*, void*);
 
-	void start(server* srv);
-	void process(server* srv);
-	void end(server* srv, bool error);
+	void start(server* srv) override;
+	void process(server* srv) override;
+	void end(server* srv, bool error) override;
 
 private:
 	std::unique_ptr<::grpc::ServerAsyncWriter<Response>> m_res_writer;
@@ -91,9 +91,9 @@ class request_context : public request_context_base
 	// Pointer to function that requests the system to start processing given requests
 	void (Service::AsyncService::*m_request_func)(::grpc::ServerContext*, Request*, ::grpc::ServerAsyncResponseWriter<Response>*, ::grpc::CompletionQueue*, ::grpc::ServerCompletionQueue*, void*);
 
-	void start(server* srv);
-	void process(server* srv);
-	void end(server* srv, bool error);
+	void start(server* srv) override;
+	void process(server* srv) override;
+	void end(server* srv, bool error) override;
 
 private:
 	std::unique_ptr<::grpc::ServerAsyncResponseWriter<Response>> m_res_writer;
@@ -115,9 +115,9 @@ class request_bidi_context : public request_context_base
 	// Pointer to function that requests the system to start processing given requests
 	void (Service::AsyncService::*m_request_func)(::grpc::ServerContext*, ::grpc::ServerAsyncReaderWriter<Response, Request>*, ::grpc::CompletionQueue*, ::grpc::ServerCompletionQueue*, void*);
 
-	void start(server* srv);
-	void process(server* srv);
-	void end(server* srv, bool error);
+	void start(server* srv) override;
+	void process(server* srv) override;
+	void end(server* srv, bool error) override;
 
 private:
 	std::unique_ptr<::grpc::ServerAsyncReaderWriter<Response, Request>> m_reader_writer;

diff --git a/userspace/falco/outputs_file.h b/userspace/falco/outputs_file.h
@@ -28,11 +28,11 @@ namespace outputs
 
 class output_file : public abstract_output
 {
-	void output(const message *msg);
+	void output(const message *msg) override;
 
-	void cleanup();
+	void cleanup() override;
 
-	void reopen();
+	void reopen() override;
 
 private:
 	void open_file();

diff --git a/userspace/falco/outputs_grpc.h b/userspace/falco/outputs_grpc.h
@@ -26,7 +26,7 @@ namespace outputs
 
 class output_grpc : public abstract_output
 {
-	void output(const message *msg);
+	void output(const message *msg) override;
 };
 
 } // namespace outputs

diff --git a/userspace/falco/outputs_program.h b/userspace/falco/outputs_program.h
@@ -26,11 +26,11 @@ namespace outputs
 
 class output_program : public abstract_output
 {
-	void output(const message *msg);
+	void output(const message *msg) override;
 
-	void cleanup();
+	void cleanup() override;
 
-	void reopen();
+	void reopen() override;
 
 private:
 	void open_pfile();

diff --git a/userspace/falco/outputs_stdout.h b/userspace/falco/outputs_stdout.h
@@ -26,9 +26,9 @@ namespace outputs
 
 class output_stdout : public abstract_output
 {
-	void output(const message *msg);
+	void output(const message *msg) override;
 
-	void cleanup();
+	void cleanup() override;
 };
 
 } // namespace outputs

diff --git a/userspace/falco/outputs_syslog.h b/userspace/falco/outputs_syslog.h
@@ -26,7 +26,7 @@ namespace outputs
 
 class output_syslog : public abstract_output
 {
-	void output(const message *msg);
+	void output(const message *msg) override;
 };
 
 } // namespace outputs