Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(cmd): default unix socket path for Falco 0.33 #76

Merged
merged 4 commits into from
Oct 21, 2022
Merged

update(cmd): default unix socket path for Falco 0.33 #76

merged 4 commits into from
Oct 21, 2022

Conversation

leogr
Copy link
Member

@leogr leogr commented Oct 21, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area examples

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added kind/cleanup Things to cleanup do-not-merge/work-in-progress dco-signoff: yes kind/feature New feature or request area/commands Issues about falco-exporter commands labels Oct 21, 2022
@poiana poiana requested a review from jasondellaluce October 21, 2022 10:38
@poiana poiana added size/S and removed size/XS labels Oct 21, 2022
@poiana poiana added size/M and removed size/S labels Oct 21, 2022
@leogr leogr changed the title wip: update(cmd): default unix socket path for Falco 0.33 update(cmd): default unix socket path for Falco 0.33 Oct 21, 2022
jasondellaluce
jasondellaluce approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 21, 2022
@poiana
Copy link

poiana commented Oct 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f279c7b into master Oct 21, 2022
@poiana poiana deleted the update/falco-0-33 branch October 21, 2022 13:46
@leogr leogr mentioned this pull request Dec 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

Assignees

@jasondellaluce jasondellaluce

Labels
approved area/commands Issues about falco-exporter commands dco-signoff: yes kind/cleanup Things to cleanup kind/feature New feature or request lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogr @poiana @jasondellaluce