Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brand and URL references #67

Merged
merged 5 commits into from
Apr 28, 2021
Merged

Update brand and URL references #67

merged 5 commits into from
Apr 28, 2021

Conversation

maxgio92
Copy link
Member

What type of PR is this?

/kind bug
/kind documentation

Any specific area of the project related to this PR?

/area integrations
/area examples

What this PR does / why we need it:

This PR updates Sysdig references to Falco ones, from documentation to integrations, like Falco APT and RPM repositories in the Puppet module.

@poiana poiana added kind/bug Something isn't working kind/documentation Improvements or additions to documentation dco-signoff: no labels Apr 28, 2021
@poiana
Copy link
Contributor

poiana commented Apr 28, 2021

@maxgio92: The label(s) area/integrations, area/examples cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug
/kind documentation

Any specific area of the project related to this PR?

/area integrations
/area examples

What this PR does / why we need it:

This PR updates Sysdig references to Falco ones, from documentation to integrations, like Falco APT and RPM repositories in the Puppet module.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana requested review from leogr and nestorsalceda April 28, 2021 09:40
@poiana poiana added the size/M label Apr 28, 2021
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on typos!

Thanks for submitting this Max 🤗

@maxgio92
Copy link
Member Author

Thank you @leodido !
There are still references in /deploy/kubernetes/falco/templates/configmap.yaml, but they come from the default Falco ruleset.
Maybe we can review also them, as I saw that they're referencing for instance docker.io/sysdig/falco image, while the current one comes from docker.io/falcosecurity/falco repository AFAIK. WDYT?

@leodido
Copy link
Member

leodido commented Apr 28, 2021

Thank you @leodido !
There are still references in /deploy/kubernetes/falco/templates/configmap.yaml, but they come from the default Falco ruleset.
Maybe we can review also them, as I saw that they're referencing for instance docker.io/sysdig/falco image, while the current one comes from docker.io/falcosecurity/falco repository AFAIK. WDYT?

Oh, yes docker.io/sysdig/falco (and also sysdig/falco) should be removed. Those are 4 years old images we don't publish and no one uses (AFAIK).

I suggest you to do that in a follow-up PR to keep things simple.

Anyways, this topic would definitely need an issue also in the Falco repository! Mind opening it Max? :)

@poiana
Copy link
Contributor

poiana commented Apr 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 28, 2021

LGTM label has been added.

Git tree hash: d4b7cb8a1e12c6b7aa9261090c6e7bd525014815

@poiana poiana merged commit 33a3025 into master Apr 28, 2021
@poiana poiana deleted the fix/update-falco-brand branch April 28, 2021 13:08
@maxgio92
Copy link
Member Author

Sure @leodido

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes kind/bug Something isn't working kind/documentation Improvements or additions to documentation lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants