Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(pkg,docker): added an amazonlinux2 gcc10 builder. #346

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 12, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build
/area pkg

What this PR does / why we need it:

This fixes driver build issues on al2 5.10 kernels triggered by the new kmod configure system.

Which issue(s) this PR fixes:

Refs: falcosecurity/falco#3244

Fixes #

Special notes for your reviewer:

Already tested by pushing on my fededp dockerhub repo:

2024-06-12 09:45:42 DEBUG [configure-kmod] Setting HAS_ACCESS_OK_2 flag 
2024-06-12 09:45:45 DEBUG Built target driver 
2024-06-12 09:45:45 DEBUG + strip -g /tmp/driver/build/driver/falco.ko 
2024-06-12 09:45:45 DEBUG + modinfo /tmp/driver/build/driver/falco.ko 
2024-06-12 09:45:45 DEBUG filename:       /tmp/driver/build/driver/falco.ko 
2024-06-12 09:45:45 DEBUG schema_version: 2.20.2 
2024-06-12 09:45:45 DEBUG api_version:    8.0.3 
2024-06-12 09:45:45 DEBUG build_commit:   master 
2024-06-12 09:45:45 DEBUG version:        master 
2024-06-12 09:45:45 DEBUG author:         the Falco authors 
2024-06-12 09:45:45 DEBUG license:        Dual MIT/GPL 
2024-06-12 09:45:45 DEBUG srcversion:     0D89FFD4425AF0AC0B4E713 
2024-06-12 09:45:45 DEBUG depends:         
2024-06-12 09:45:45 DEBUG retpoline:      Y 
2024-06-12 09:45:45 DEBUG name:           falco 
2024-06-12 09:45:45 DEBUG vermagic:       5.10.217-205.860.amzn2.x86_64 SMP mod_unload modversions 

Does this PR introduce a user-facing change?:

new(pkg,docker): added an amazonlinux2 gcc10 builder.

This fixes driver build issues on al2 5.10 kernels.

Signed-off-by: Federico Di Pierro <[email protected]>
@poiana poiana added kind/feature New feature or request dco-signoff: yes area/build Further information is requested area/pkg labels Jun 12, 2024
@poiana poiana requested review from leodido and Lowaiz June 12, 2024 07:58
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 12, 2024

/cc @LucaGuerra

@poiana poiana requested a review from LucaGuerra June 12, 2024 07:58
@poiana poiana added the size/M label Jun 12, 2024
@@ -179,6 +180,14 @@ func (a *amazonlinux2) URLs(kr kernelrelease.KernelRelease) ([]string, error) {
return fetchAmazonLinuxPackagesURLs(a, kr)
}

func (a *amazonlinux2) GCCVersion(kr kernelrelease.KernelRelease) semver.Version {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement GCCVersionRequestor interface to override gcc used for 5.10 kernels (enforcing gcc-10).

@poiana
Copy link

poiana commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9e6dca8 into master Jul 19, 2024
8 checks passed
@poiana poiana deleted the new/al2_gcc10_builder branch July 19, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants