-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/builder.md: remove BuilderByTarget references #345
Conversation
The 'Target name' subsection is old. BuilderByTarget isn't used anymore; it's now 'byTarget' in target.go. Add a hyperlink for clarity and accessibility. Signed-off-by: Enzo Venturi <[email protected]>
Welcome @nnzv! It looks like this is your first PR to falcosecurity/driverkit 🎉 |
/assign FedeDP |
Hi! |
docs/builder.md: remove BuilderByTarget references Signed-off-by: Enzo Venturi <[email protected]>
Thanks for pointing that out. Didn't notice. Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 9db885e3ab116fab373b9f17d51bc198be254f95
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, nnzv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The 'Target name' subsection is old.
BuilderByTarget
isn't used anymore; it's nowbyTarget
intarget.go
. Add a hyperlink for clarity and accessibility.What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area pkg
/area docs
What this PR does / why we need it:
The commit by @FedeDP seems to have caused this 56573f4, but it appears that the documentation hasn't been updated to match the current logic of the builders.
Which issue(s) this PR fixes:
Special notes for your reviewer:
No
Does this PR introduce a user-facing change?:
No