Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changes for updated green reviews pipeline #18

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Jul 2, 2024

This PR makes 3 changes to the current structure to align with recent changes to the green reviews pipeline.

  • Updates the repo structure to have a separate kustomization for each driver. So reach can be deployed independently.
  • Updates node selector to use a new label node-role.kubernetes.io/benchmark: "true" for all 3 drivers
  • Moves benchmark tests to a new dir called /benchmark-tests

@poiana poiana requested review from leogr and maxgio92 July 2, 2024 17:25
@poiana
Copy link

poiana commented Jul 2, 2024

Welcome @rossf7! It looks like this is your first PR to falcosecurity/cncf-green-review-testing 🎉

@poiana poiana added the size/L label Jul 2, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks a bunch 🚀 !

@poiana
Copy link

poiana commented Jul 2, 2024

LGTM label has been added.

Git tree hash: b3183c6ceb08b7aef778a79507da3d310d538d04

@poiana
Copy link

poiana commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, rossf7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jul 2, 2024
@poiana poiana merged commit b17c6d7 into falcosecurity:main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants