-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Run pyupgrade --py38-plus, remove mentions of lower python versions #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, but we could add also 3.11 and 12
I guess it closes #37 too |
As mentioned on another PR, we haven't decided yet how we are going to bundle or unbundle this into Falcon going forward, but let's follow Falcon's suit and don't hard-drop 3.7 yet. I.e. we can keep saying in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's resurrect 3.7 support in setup.cfg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I wouldn't like to introduce such difference between the readme and the config. Also, running pyupgrade |
That's a valid point too, works both ways for me. |
Didn't touch the travis file. I'm guessing it should be removed.
Fixes #37