Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run pyupgrade --py38-plus, remove mentions of lower python versions #47

Merged
merged 5 commits into from
Jan 2, 2024
Merged

chore: Run pyupgrade --py38-plus, remove mentions of lower python versions #47

merged 5 commits into from
Jan 2, 2024

Conversation

rafalkrupinski
Copy link
Contributor

@rafalkrupinski rafalkrupinski commented Jan 1, 2024

Didn't touch the travis file. I'm guessing it should be removed.

Fixes #37

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, but we could add also 3.11 and 12

@rafalkrupinski
Copy link
Contributor Author

I guess it closes #37 too

@CaselIT CaselIT requested a review from vytas7 January 2, 2024 08:24
@vytas7
Copy link
Member

vytas7 commented Jan 2, 2024

As mentioned on another PR, we haven't decided yet how we are going to bundle or unbundle this into Falcon going forward, but let's follow Falcon's suit and don't hard-drop 3.7 yet.

I.e. we can keep saying in the README that we only support 3.8+, but python_requires should still allow 3.7.

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resurrect 3.7 support in setup.cfg

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rafalkrupinski
Copy link
Contributor Author

I.e. we can keep saying in the README that we only support 3.8+, but python_requires should still allow 3.7.

I wouldn't like to introduce such difference between the readme and the config.

Also, running pyupgrade --py37-plus didn't introduce any changes versus --py-38-plus, so no code changes.

@vytas7 vytas7 merged commit 77e46f0 into falconry:master Jan 2, 2024
11 checks passed
@vytas7
Copy link
Member

vytas7 commented Jan 2, 2024

I wouldn't like to introduce such difference between the readme and the config.

That's a valid point too, works both ways for me. python_requires is what is required for installation, but "support" might mean different things though, like support as in bug reports are considered for, etc.

@vytas7 vytas7 mentioned this pull request Jan 2, 2024
@rafalkrupinski rafalkrupinski deleted the pyupgrade branch January 2, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop python 2
3 participants