Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace api for GuessThePokemon command #11

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

Vinicius-Marques6
Copy link
Contributor

What does this PR do?

Now we utilize the PokéApi, a famous and solid api for getting pokemon data. First we get the answer image, then we manipulate it to turn all black and send to the user guess it.

Summary of changes

Media

GuessThePokemonTest.mp4

Status

  • These changes have been tested and formatted properly.
  • These changes also include the change in documentation accordingly.
  • This PR introduces some Breaking changes.

Now we utilize the PokéApi, a famous and solid api for getting pokemon data. First we get the answer image, then we manipulate it to turn all black and send to the user guess it.
src/GuessThePokemon.js Outdated Show resolved Hide resolved
Copy link
Owner

@falcao-g falcao-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice! thank you :)

@falcao-g falcao-g merged commit 90d65f3 into falcao-g:main Feb 22, 2024
@Vinicius-Marques6 Vinicius-Marques6 deleted the fix/guess-the-pokemon branch February 22, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants