Fix crash for remote sessions (#81)

falbru · Dec 28, 2024 · b72531e · b72531e
1 parent fc72cad
commit b72531e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/src/kakounesession.cpp b/src/kakounesession.cpp
@@ -75,15 +75,18 @@ KakouneSession::KakouneSession(QString session_id, QStringList session_arguments
 
 KakouneSession::~KakouneSession()
 {
-    QProcess kill_session;
-    kill_session.start("kak", {"-p", m_session_id});
-    kill_session.waitForStarted();
-    kill_session.write("kill");
-    kill_session.closeWriteChannel();
-    kill_session.waitForFinished();
-    kill_session.close();
-
-    m_process->close();
+    if (m_process != nullptr)
+    {
+        QProcess kill_session;
+        kill_session.start("kak", {"-p", m_session_id});
+        kill_session.waitForStarted();
+        kill_session.write("kill");
+        kill_session.closeWriteChannel();
+        kill_session.waitForFinished();
+        kill_session.close();
+
+        m_process->close();
+    }
 }
 
 QString KakouneSession::getSessionId()

diff --git a/src/kakounewidget.cpp b/src/kakounewidget.cpp
@@ -51,7 +51,6 @@ QSize KakouneWidget::sizeHint() const
 
 KakouneWidget::~KakouneWidget()
 {
-    delete m_client;
 }
 
 QUuid KakouneWidget::getID()
-Original file line number
+Diff line change
@@ Expand Up / @@ -51,7 +51,6 @@ QSize KakouneWidget::sizeHint() const @@
     KakouneWidget::~KakouneWidget()
     {
-        delete m_client;
     }
     QUuid KakouneWidget::getID()
@@ Expand Down @@