Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): prepare JEST CI verification job integration in G-A for client SPA app #51

Merged
merged 1 commit into from
May 31, 2024

Conversation

bougwal
Copy link
Collaborator

@bougwal bougwal commented May 31, 2024

Hey @falberthen - I hope you are well! A Friday evening PR, as per our last discussion yesterday- Let me know what you think about running the client app unit tests with jest in the pipeline - As we add more unit tests in the future, the business logic should be very well covered - Still as discussed, the UI part can be addressed too with either extended jest DOM tests or one of the available options (cypress or playwright) in the future.

@bougwal bougwal requested a review from falberthen May 31, 2024 16:22
@falberthen
Copy link
Owner

Hey @falberthen - I hope you are well! A Friday evening PR, as per our last discussion yesterday- Let me know what you think about running the client app unit tests with jest in the pipeline - As we add more unit tests in the future, the business logic should be very well covered - Still as discussed, the UI part can be addressed too with either extended jest DOM tests or one of the available options (cypress or playwright) in the future.

I fully agree with that! Thank you for this update, @bougwal !

@falberthen falberthen closed this May 31, 2024
@falberthen falberthen reopened this May 31, 2024
@falberthen falberthen merged commit 9d77b4f into master May 31, 2024
4 checks passed
@bougwal bougwal deleted the feature/ci-fe-jest branch June 1, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants