This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
refactor: move some hacks location #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mederka
approved these changes
Feb 6, 2023
Comment on lines
+97
to
+105
| def get_relation(self, database: str, schema: str, identifier: str): | ||
| # HACK: When compiling Python models, we get an all-False quoting policy | ||
| # This does not happen in 1.4 | ||
| if self._db_adapter.type() == "athena": | ||
| # and dbt-athena-community breaks for that case | ||
| self.config.quoting = {"database": True, "schema": True, "identifier": True} | ||
|
|
||
| return self._db_adapter.get_relation(database, schema, identifier) | ||
|
|
There was a problem hiding this comment.
NIT: Does it matter if we put it in a wrapper or in impl.py? I think impl.py is better because it's more visible there. This feels more like putting something under a rug.
There was a problem hiding this comment.
The way I saw this change was taking it from the "general" soluton of the Adapter Mixin and putting it in the wrapper that is actually being used, since this is 1.3-specific and will not be replicated for 1.4
There was a problem hiding this comment.
merging and you can make a decision in your PR
Great suggestion, but this is not going into |
mederka
added a commit
that referenced
this pull request
Feb 6, 2023
* tests(dbt-fal): add athena profile * feat: add dbt-athena-community support dbt-athena from PyPI doesn't support dbt 1.3, but dbt-athena-community does https://github.com/dbt-athena/dbt-athena dbt-athena-community does not support dbt 1.4, so this branch doesn't need to be merged to main. Instead, we will release a patch to dbt-fal 1.3 in order to add support to dbt-athena-community * PR comments * refactor: move some hacks location (#742) --------- Co-authored-by: Matteo Ferrando <[email protected]>
chamini2
added a commit
that referenced
this pull request
Feb 9, 2023
* tests(dbt-fal): add athena profile * feat: add dbt-athena-community support dbt-athena from PyPI doesn't support dbt 1.3, but dbt-athena-community does https://github.com/dbt-athena/dbt-athena dbt-athena-community does not support dbt 1.4, so this branch doesn't need to be merged to main. Instead, we will release a patch to dbt-fal 1.3 in order to add support to dbt-athena-community * PR comments * refactor: move some hacks location (#742) --------- Co-authored-by: Matteo Ferrando <[email protected]>
chamini2
added a commit
that referenced
this pull request
Feb 10, 2023
* tests(dbt-fal): add athena profile * feat: add dbt-athena-community support dbt-athena from PyPI doesn't support dbt 1.3, but dbt-athena-community does https://github.com/dbt-athena/dbt-athena dbt-athena-community does not support dbt 1.4, so this branch doesn't need to be merged to main. Instead, we will release a patch to dbt-fal 1.3 in order to add support to dbt-athena-community * PR comments * refactor: move some hacks location (#742) --------- Co-authored-by: Matteo Ferrando <[email protected]>
chamini2
added a commit
that referenced
this pull request
Feb 10, 2023
* tests(dbt-fal): add athena profile * feat: add dbt-athena-community support dbt-athena from PyPI doesn't support dbt 1.3, but dbt-athena-community does https://github.com/dbt-athena/dbt-athena dbt-athena-community does not support dbt 1.4, so this branch doesn't need to be merged to main. Instead, we will release a patch to dbt-fal 1.3 in order to add support to dbt-athena-community * PR comments * refactor: move some hacks location (#742) --------- Co-authored-by: Matteo Ferrando <[email protected]>
mederka
added a commit
that referenced
this pull request
Apr 4, 2023
* tests(dbt-fal): add athena profile * feat: add dbt-athena-community support dbt-athena from PyPI doesn't support dbt 1.3, but dbt-athena-community does https://github.com/dbt-athena/dbt-athena dbt-athena-community does not support dbt 1.4, so this branch doesn't need to be merged to main. Instead, we will release a patch to dbt-fal 1.3 in order to add support to dbt-athena-community * PR comments * refactor: move some hacks location (#742) --------- Co-authored-by: Matteo Ferrando <[email protected]>
mederka
added a commit
that referenced
this pull request
Apr 4, 2023
* feat(dbt-adapter): dbt-athena-community support (#741) * tests(dbt-fal): add athena profile * feat: add dbt-athena-community support dbt-athena from PyPI doesn't support dbt 1.3, but dbt-athena-community does https://github.com/dbt-athena/dbt-athena dbt-athena-community does not support dbt 1.4, so this branch doesn't need to be merged to main. Instead, we will release a patch to dbt-fal 1.3 in order to add support to dbt-athena-community * PR comments * refactor: move some hacks location (#742) --------- Co-authored-by: Matteo Ferrando <[email protected]> * remove 1.3-specific hack * Add tests * comments * Fix test setup * update athena profile * fix credential parsing in isolated envs --------- Co-authored-by: Matteo Ferrando <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: the quoting was fixed in dbt for 1.4+ in dbt-labs/dbt-core#6620