Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close the child process #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jackfiszr
Copy link

Not closing the process causes:

error: AssertionError: Test case is leaking 3 resources:

 - A child process stdout (rid 3) was opened during the test, but not closed during the test. Close the child process stdout by calling `proc.stdout.close()`.      
 - A child process stderr (rid 4) was opened during the test, but not closed during the test. Close the child process stderr by calling `proc.stderr.close()`.      
 - A child process (rid 5) was started during the test, but not closed during the test. Close the child process by calling `proc.kill()` or `proc.close()`.

    at assert (deno:ext/web/00_infra.js:294:13)
    at resourceSanitizer (deno:runtime/js/40_testing.js:407:7)
    at async Object.exitSanitizer [as fn] (deno:runtime/js/40_testing.js:425:9)
    at async runTest (deno:runtime/js/40_testing.js:831:7)
    at async Object.runTests (deno:runtime/js/40_testing.js:1084:22)

...when testing code that uses the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant