-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html generator for Faker #2769
Html generator for Faker #2769
Conversation
Hi @thdaraujo, Have added the documentation and fixed the flaky spec #2798 as well, Please check. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really interesting, thanks for working on this!
I left some comments as I would like to keep this generator similar to the markdown one, but I also added some suggestions for improvement.
@thdaraujo Have resolved your comments, Please take a look. 😄 |
@stefannibrasil I have added the version and addressed your comments. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruban-thilak thank you for the changes! I had more time today to test the generators. Looking good, just added a few more comments.
@stefannibrasil I have made the suggested changes. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'm actually working with HTML parsing, so this came out in a good timing. Thank you!
Is there a timeline to publish v 3.2.1? (I know this is only 2 days old, so not trying to pester) |
I'm planning on doing a release this Friday. In the meantime, feel free use the main branch. Thanks! |
Motivation / Background
This Pull Request has been created because Faker doesn't have an html generator, and this can be used for testing HTML sanitizers or email bodies containing HTML, etc.
Additional information
I implemented this generator by referring to the existing implementation of the markdown generator available in Faker.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
If you're proposing a new generator: