Update South Park #2744
Update South Park #2744
Conversation
doc/tv_shows/south_park.md
Outdated
| @@ -4,4 +4,6 @@ | |||
| Faker::TvShows::SouthPark.character #=> "Mr. Garrison" | |||
|
|
|||
| Faker::TvShows::SouthPark.quote #=> "I'm just getting a little cancer Stan" | |||
|
|
|||
| Faker::TvShows::SouthPark.episode #=> "Make Love, Not Warcraft" | |||
There was a problem hiding this comment.
Have you thought of using episode_name instead of just episode? When I read "episode", I'm not sure if it means the name, the number, the full name, i.e, S01 EP01, so defining it explicitly helps with that.
There was a problem hiding this comment.
Need to update the docs as well @IvanReyesO7
| @@ -1,5 +1,418 @@ | |||
| en: | |||
| faker: | |||
| south_park: | |||
| characters: ["Sharon Marsh", "Officer Barbrady", "Jesus", "Token Black", "Dr. Alphonse Mephesto", "Stephen Stotch", "Heidi Turner", "Jimmy Valmer", "Sheila Broflovski", "Jimbo Kern", "Ike Broflovski", "Kevin McCormick", "Father Maxi", "Grandpa Marvin Marsh", "Clyde Donovan", "Butters Stotch", "Shelly Marsh", "Kyle Broflovski", "Stuart McCormick", "Carol McCormick", "Timmy Burch", "Ned Gerblansky", "Mr. Mackey", "Satan", "Moses", "PC Principal", "Bradley Biggle", "Randy Marsh", "Kenny McCormick", "Terrance and Phillip", "Mr. Slave", "Sergeant Harrison Yates", "Lemmiwinks", "Mr. Hankey", "Wendy Testaburger", "Santa", "God", "Stan Marsh", "Towelie", "Gerald Broflovski", "Bebe Stevens", "Starvin' Marvin", "Karen McCormick", "David Rodriguez", "Eric Cartman", "Mayor McDaniels", "Tuong Lu Kim", "Tweek Tweak", "Dougie", "Craig Tucker", "Mr. Garrison", "Pip", "Liane Cartman", "Scott Malkinson", "Linda Stotch"] | |||
| quotes: ["Hippies. They're everywhere. They wanna save Earth, but all they do is smoke pot and smell bad", "They took our deers", "Kenny’s family is so poor that yesterday, they had to put their cardboard box up for a second mortgage", "Without evil there could be no good, so it must be good to be evil sometimes", "Dad, Tom Cruise won't come out of the closet!", "They took der derrs", "I'm not just sure, I'm HIV positive", "I don't make the rules Kyle, I simply think them up and write them down", "I'm just getting a little cancer Stan", "Respect my authoritaahh!!!", "Your mother was worried sick and I was here drinking beer", "Hey Panda Bear! We don't take kindly to your types around here.", "You know what they say: You can't teach a gay dog straight tricks", "They took our jobs", "Maybe we should send you to a concentration camp", "Life is short butters, & thats why you have to do whatever you want all the time", "No we haven't actually seen it Tom, we're just reporting it"] | |||
| characters: | |||
There was a problem hiding this comment.
I know this hasn't been documented anywhere in the library but adding any quotes that involve sexuality, gender, and other quotes/characters/episodes that might be offensive to some people is not what Faker is intended to be.
Please, could you leave out the ones that involve body parts, sexual orientation, violence, and any other words that are not inclusive? Thank you.
| - Karen McCormick | ||
| - Kenny McCormick | ||
| - Kevin McCormick |
There was a problem hiding this comment.
| - Karen McCormick | |
| - Kenny McCormick | |
| - Kevin McCormick | |
| - Karen McCormick |
There was a problem hiding this comment.
@stefannibrasil Thank you for reviewing this!
Those three are different characters with the same family name.
There was a problem hiding this comment.
That was easy to get it wrong 😆
doc/tv_shows/south_park.md
Outdated
| @@ -4,4 +4,6 @@ | |||
| Faker::TvShows::SouthPark.character #=> "Mr. Garrison" | |||
|
|
|||
| Faker::TvShows::SouthPark.quote #=> "I'm just getting a little cancer Stan" | |||
|
|
|||
| Faker::TvShows::SouthPark.episode #=> "Make Love, Not Warcraft" | |||
There was a problem hiding this comment.
Need to update the docs as well @IvanReyesO7
Summary
Other Information