Add Final Fantasy XIV #2742
Add Final Fantasy XIV #2742
Conversation
Adds characters, jobs, races, data centers and zones from the video game Final Fantasy XIV.
ghost
changed the title
|
One question/note, I did not make any changes to the README.md file. This would be in relation to the Should this be done in this PR? (I presume not, but figured I should ask). |
Yes! You're right. I think we probably need to update the PR templates to clarify that, thanks for pointing it out. Could you include the new generator in the README? Thanks! There are some errors that need to be fixed first. Could you try rebasing with main? |
|
PR template updated in #2749 |
|
@stefannibrasil Updated. Thank you. I'm unsure what steps are next (first time contributing to Faker). |
| games: | ||
| final_fantasy_xiv: | ||
| characters: | ||
| - Alphinaud Leveilleur |
There was a problem hiding this comment.
weird, the CI is complaining about this:
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/i18n-1.12.0/lib/i18n/backend/base.rb:254:in `rescue in load_yml': can not load translations from /home/runner/work/faker/faker/lib/locales/en/final_fantasy_xiv.yml: #<Psych::SyntaxError: (/home/runner/work/faker/faker/lib/locales/en/final_fantasy_xiv.yml): did not find expected '-' indicator while parsing a block collection at line 6 column 11> (I18n::InvalidLocaleData)
does the test suite work for you locally?
There was a problem hiding this comment.
Ah, I did, and thought I had before I pushed again, after adding a lot of names. Admittedly a lot of copy/paste done.
The name 'Dozol... starts with a single quote (good 'ol FFXIV naming) which threw off the YML parsing.
Most recent push corrects this locally and corrects typo in .md file as you noted.
ghost
requested a review
from
First-time contributors need a maintainer approval to run CI. If it passes, and it's approved, the PR can be merged. I will leave this to @thdaraujo since he's been reviewing it since the beginning. Thanks! |
Summary
Adds characters, jobs, races, data centers and zones from the video game Final Fantasy XIV.
This is based on the current World of Warcraft pattern previously implemented in Faker.
Resources used (for those wanting to add/audit data):
☄️