Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple typo in es.yml #2675

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

hslzr
Copy link
Contributor

@hslzr hslzr commented Jan 2, 2023

Summary

In lib/locales/es.yml, the last name Hernández was written as Hernádez. It's not an uncommon last name, very widespread in Latin América as well.

Does a Wikipedia article count as proof?

@hslzr
Copy link
Contributor Author

hslzr commented Jan 2, 2023

The diff looks messy because it's all in one line, hopefully this image can make it easier to see.

Fix_simple_typo_in_es_yml_by_hslzr_·Pull_Request__2675·_faker-ruby_faker

@psibi psibi merged commit 3e26196 into faker-ruby:main Jan 3, 2023
@psibi
Copy link
Member

psibi commented Jan 3, 2023

Thank you!

@hslzr hslzr deleted the es-locale-typo-fix branch January 17, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants