Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Mountain #2196

Merged
merged 6 commits into from
Nov 22, 2020
Merged

Add Faker::Mountain #2196

merged 6 commits into from
Nov 22, 2020

Conversation

bipashant
Copy link
Contributor

@bipashant bipashant commented Nov 21, 2020 •
edited
Loading

No-Story

Description:

Add a generator to generate mountain names and ranges.

Faker::Mountain.name #=> "Mount Everest"
Faker::Mountain.range #=> "Dhaulagiri Himalaya"

@psibi psibi merged commit caa4c35 into faker-ruby:master Nov 22, 2020
@psibi
Copy link
Member

psibi commented Nov 22, 2020

Thanks!

@sudeeptarlekar
Copy link
Contributor

@bipashant can we add docs and add entry for same in README?

cc: @psibi

@bipashant
Copy link
Contributor Author

@sudeeptarlekar
Created new pull request faker#2205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psibi psibi psibi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bipashant @psibi @sudeeptarlekar