Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add japanese gender first name #2191

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

ise-tang
Copy link
Contributor

@ise-tang ise-tang commented Nov 10, 2020

irb(main):001:0> Faker::Name.name
=> "西村 匠" # correct japanese name
irb(main):002:0> Faker::Name.male_first_name
=> "颯太" # correct japanese male name
irb(main):003:0> Faker::Name.female_first_name
=> "陽菜" # correct japanse female name
irb(main):004:0> Faker::Name.first_name
=> "美咲"

Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@issei126 Thanks for the MR, but this requires minor changes.

lib/locales/ja.yml Show resolved Hide resolved
@psibi psibi merged commit a1ffab7 into faker-ruby:master Nov 11, 2020
@psibi
Copy link
Member

psibi commented Nov 11, 2020

Thanks!

@ise-tang ise-tang deleted the feature/japanese_gender_first_name branch November 11, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants