Add HTTP status codes generator

[willianveiga]

Description:

Add HTTP status codes generator:

Faker::Internet::HTTP.status_code # 302

Faker::Internet::HTTP.information_status_code # 101

Faker::Internet::HTTP.successful_status_code # 200

Faker::Internet::HTTP.redirect_status_code # 301

Faker::Internet::HTTP.client_error_status_code # 404

Faker::Internet::HTTP.server_error_status_code # 500

[vbrazo]

Please add /docs and update the README.

[vbrazo]

I wonder if we really need a new object. We could simply do Faker::Internet.http_status_code to get a status code. Thoughts?

[vbrazo]

Another idea would be passing the status code error message in the parameter instead of having the interface methods. I meanFaker::Internet.http_status_code(status_error: :client_error). If you don't pass anything, you'd return a random status_error code.

[vbrazo]

I see that you want to add the Faker::Internet::HTTP generator.

Ok no problem! Just one question for you:

Which other faker interface methods do you believe we could add to this new object?

If we only have this method inside this new generator, I'd definitely prefer to move this to Faker::Internet.http_status_code. If you can tell me other useful methods, then we could see if we move on with this new object.

[willianveiga]

A new class would help me to separate concerns. HTTP is a different Internet concern. I can avoid breaking the Single Responsibility Principle and organize things better.

We could have a new method returning HTTP status codes as symbols (:ok, :forbidden, etc.), for example.

I think we can leave it as it is now and we can refactor it later in new PR, when I'll add this new method described above. What do you think, @vbrazo?

Thank you very much.

[vbrazo]

@faker-ruby/core-contributors thoughts?

[jremes-foss]

@vbrazo @faker-ruby/core-contributors Add a new class. The separation of concerns is a valid point.

[Zeragamba]

new generators should have version next

[jremes-foss]

Hi. Looks like the failing build was caused by RuboCop:

lib/faker/default/internet_http.rb:19:1: C: Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.

Please fix.

[willianveiga]

Should I add next here, @Zeragamba ? 🤔

[Zeragamba]

Yep

[psibi]

Minor comment

[koic]

Thanks!