-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): generate all locales index files with non-any types #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #494 +/- ##
========================================
Coverage 99.34% 99.34%
========================================
Files 1919 1919
Lines 176165 176333 +168
Branches 903 902 -1
========================================
+ Hits 175008 175175 +167
- Misses 1101 1102 +1
Partials 56 56
|
Shinigami92
reviewed
Feb 16, 2022
Co-authored-by: Shinigami <[email protected]>
Shinigami92
approved these changes
Feb 16, 2022
prisis
approved these changes
Feb 16, 2022
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
ST-DDT
modified the milestones:
v6 - Non-Breaking Changes,
v6.0 - Ensure Project Foundation
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485
This PR fixes 39 warnings (273 -> 234).