-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enable test to generate Number.MAX_SAFE_INTEGER #3393
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3393 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2811 2811
Lines 216965 216965
Branches 941 940 -1
==========================================
- Hits 216914 216912 -2
- Misses 51 53 +2 |
Just a little thingy I observed here in the PR: Looks like the |
We could do that 🤷♂️ , but we havent sealed any other object/module either. |
I played a bit around with it, and it makes to many bad side-effects in tests, snapshots and other things like auto-doc-get. So I decided against touching it. 👌 |
I checked the codebase for todos and found this disabled test, so I fixed and enabled it.
The tests have been added in v8.4.0
And should have been enabled in v9.0.0-alpha.0 two months later