Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): improve product_name data in en and tr #3372

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

k-salih
Copy link
Contributor

@k-salih k-salih commented Jan 13, 2025

For en locale, Frozen, Fresh, and Soft were in materials category although they should have been in adjectives. I moved them and also expanded the materials category.

For the tr locale, I did the corresponding changes for the same items. Translations are confirmed by me as a native Turkish speaker. Below you can see which corresponds to which:

Dondurulmuş(Frozen), Taze(Fresh), Yumuşak(Soft), Altın(Gold), Alüminyum(Aluminum), Bambu(Bamboo), Mermer(Marble), Seramik(Ceramic), İpek(Silk)

@k-salih k-salih requested a review from a team as a code owner January 13, 2025 21:18
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 27e80eb
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/678594ba9f13090008afff41
😎 Deploy Preview https://deploy-preview-3372.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module m: commerce Something is referring to the commerce module and removed m: company Something is referring to the company module labels Jan 13, 2025
@ST-DDT ST-DDT added this to the vAnytime milestone Jan 13, 2025
@ST-DDT
Copy link
Member

ST-DDT commented Jan 13, 2025

Nice catch.

Please run pnpm run preflight and commit the changes.

@ST-DDT ST-DDT requested review from a team January 13, 2025 23:27
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (bddce72) to head (27e80eb).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3372   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      217023   217035   +12     
  Branches      942      941    -1     
=======================================
+ Hits       216970   216982   +12     
  Misses         53       53           
Files with missing lines Coverage Δ
src/locales/en/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/tr/commerce/product_name.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added this pull request to the merge queue Jan 15, 2025
@ST-DDT ST-DDT removed this pull request from the merge queue due to a manual request Jan 15, 2025
@ST-DDT ST-DDT changed the title refactor(locale): reclassify and improve product_name data in en and tr refactor(locale): improve product_name data in en and tr Jan 15, 2025
@ST-DDT ST-DDT enabled auto-merge January 15, 2025 08:44
@ST-DDT ST-DDT disabled auto-merge January 15, 2025 08:46
@ST-DDT ST-DDT added this pull request to the merge queue Jan 15, 2025
@ST-DDT ST-DDT removed this pull request from the merge queue due to a manual request Jan 15, 2025
@ST-DDT ST-DDT added this pull request to the merge queue Jan 15, 2025
Merged via the queue into faker-js:next with commit 773fc1f Jan 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants