Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): split up Spanish generic first names #3279

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 25, 2024

Preparation for #3269


Splits and deduplicates the Spanish generic first names into male and female.
I also had to fix the street name patterns, as the generic set no longer exists.

This PR does not sort the split up lists to reduce the diff.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: person Something is referring to the person module labels Nov 25, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 25, 2024
@ST-DDT ST-DDT requested review from a team November 25, 2024 09:30
@ST-DDT ST-DDT self-assigned this Nov 25, 2024
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 68599b4
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/674443b77eb113000826d9fa
😎 Deploy Preview https://deploy-preview-3279.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (56acea3) to head (68599b4).
Report is 5 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3279      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217156   217139      -17     
  Branches      982      978       -4     
==========================================
- Hits       217092   217073      -19     
- Misses         64       66       +2     
Files with missing lines Coverage Δ
src/locales/es/location/street_pattern.ts 100.00% <100.00%> (ø)
src/locales/es/person/first_name.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists contained 227 unique names before and they contain 227 unique names now. LGTM 👍

@ST-DDT ST-DDT added this pull request to the merge queue Nov 27, 2024
Merged via the queue into next with commit 5d5fe30 Nov 27, 2024
29 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/es/person/first-name/split-by-sex branch November 27, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants