Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix import styling #3273

Merged
merged 2 commits into from
Nov 21, 2024
Merged

chore: fix import styling #3273

merged 2 commits into from
Nov 21, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 19, 2024

Fixes some "broken"/badly styled imports in the scripts.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Nov 19, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 19, 2024
@ST-DDT ST-DDT requested review from a team November 19, 2024 22:32
@ST-DDT ST-DDT self-assigned this Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit fe76e2f
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/673faddc11e29c0008f36eb2
😎 Deploy Preview https://deploy-preview-3273.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (4436a77) to head (fe76e2f).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3273      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217156   217156              
  Branches      971      972       +1     
==========================================
- Hits       217066   217063       -3     
- Misses         90       93       +3     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 20, 2024

Feel free to create a PR for that.

@ST-DDT ST-DDT requested a review from a team November 20, 2024 17:29
@Shinigami92
Copy link
Member

Feel free to create a PR for that.

Maybe some day when I do active code-commits on GitHub again

@ST-DDT ST-DDT enabled auto-merge November 21, 2024 22:02
@ST-DDT ST-DDT added this pull request to the merge queue Nov 21, 2024
Merged via the queue into next with commit 3e1f26c Nov 21, 2024
23 checks passed
@ST-DDT ST-DDT deleted the chore/import/styling-cleanup branch November 21, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants