Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-export-from #3272

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 19, 2024

Ref: #2439


Enables the unicorn/prefer-export-from lint rule.

I used the playground to check whether this affects tree shaking somehow, and it doesn't have a noticeable impact on the bundle size.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Nov 19, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 19, 2024
@ST-DDT ST-DDT requested review from a team November 19, 2024 16:39
@ST-DDT ST-DDT self-assigned this Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 24ff9bb
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/673fb377fd7b830008e44e0a
😎 Deploy Preview https://deploy-preview-3272.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/locales/base/location/time_zone.ts Outdated Show resolved Hide resolved
src/locales/hr/location/county.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (56acea3) to head (24ff9bb).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3272      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217156   217153       -3     
  Branches      982      978       -4     
==========================================
- Hits       217092   217076      -16     
- Misses         64       77      +13     
Files with missing lines Coverage Δ
src/locale/index.ts 100.00% <ø> (ø)
src/locales/base/location/time_zone.ts 100.00% <ø> (ø)
src/locales/hr/location/county.ts 100.00% <ø> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant