Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): split en_AU_ocker first_names by sex #3270

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 17, 2024

Preparatory PR for #3269


Currently, the en_AU_ocker file is just a concattenated list of female and male first names.
This PR splits the generic set into female and male respectively.

This PR intentionally does not sort the elements to make it easier to review.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Nov 17, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 17, 2024
@ST-DDT ST-DDT requested review from a team November 17, 2024 13:39
@ST-DDT ST-DDT self-assigned this Nov 17, 2024
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 932acd3
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/673c7c34e1a35800083c8e20
😎 Deploy Preview https://deploy-preview-3270.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (b85d0fd) to head (932acd3).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3270      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217154   217156       +2     
  Branches      977      978       +1     
==========================================
- Hits       217076   217068       -8     
- Misses         78       88      +10     
Files with missing lines Coverage Δ
src/locales/en_AU_ocker/person/first_name.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@ST-DDT ST-DDT requested a review from a team November 17, 2024 20:55
@ST-DDT ST-DDT enabled auto-merge (squash) November 19, 2024 11:53
@ST-DDT ST-DDT merged commit b0a5ad3 into next Nov 19, 2024
23 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/en_AU_ocker/person/first_name branch November 19, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants