Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): cleanup usages of randomSeed #3260

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 12, 2024

Cleanup PR after: #3220


It looks like I missed a few places that sets a random seed the old way or in a redundant way.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: test labels Nov 12, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 12, 2024
@ST-DDT ST-DDT requested review from a team November 12, 2024 22:17
@ST-DDT ST-DDT self-assigned this Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit aeded55
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/673c7b368b76460008509f06
😎 Deploy Preview https://deploy-preview-3260.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (eae226e) to head (aeded55).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3260      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217154   217154              
  Branches      978      976       -2     
==========================================
- Hits       217087   217076      -11     
- Misses         67       78      +11     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Shinigami92
Shinigami92 previously approved these changes Nov 13, 2024
@ST-DDT ST-DDT requested a review from a team November 13, 2024 21:49
@ST-DDT ST-DDT merged commit b85d0fd into next Nov 19, 2024
23 checks passed
@ST-DDT ST-DDT deleted the test/cleanup/randomSeed branch November 19, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: test p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants