-
-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): improve Spanish color names #3230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3230 +/- ##
=======================================
Coverage 99.96% 99.97%
=======================================
Files 2805 2805
Lines 217070 217098 +28
Branches 966 972 +6
=======================================
+ Hits 216987 217034 +47
+ Misses 83 64 -19
|
ST-DDT
changed the title
refactor: Spanish color names
refactor(locale): improve Spanish color names
Oct 27, 2024
ST-DDT
added
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
m: color
Something is referring to the color module
labels
Oct 27, 2024
ST-DDT
approved these changes
Oct 27, 2024
Thanks for your contribution ❤️ |
Your changes will be included in Faker v9.2 which will be released soon (days). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
m: color
Something is referring to the color module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #2841 I propose new list for Spanish colors.