-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: remove package.json warnings #3097
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3097 +/- ##
=======================================
Coverage 99.96% 99.97%
=======================================
Files 2776 2776
Lines 226260 226260
Branches 945 943 -2
=======================================
+ Hits 226183 226201 +18
+ Misses 77 59 -18 |
Please edit the description for future reference why you opted to remove the import statement rather the default statement as suggested by the warning message. |
be1da6b
to
3c6552c
Compare
I would vote to close this in favor of #3093 |
closes #3078
I obviously choose not to remove
default
butimport
, so we fallback to simply.js
files in any other case, and do not change the runtime behavior.If we would remove
default
instead ofimport
, I highly assume it would either fail for e.g.browser
, or any other possible kind, instead of at least trying to function.If then for any other kind either something works or does not work, contributors can then still report an issue.